Add form in Student View for editing enrollment information #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome work. I’ll review tomorrow.
…On Tue, Jan 15, 2019 at 21:44 Paul Bitutsky ***@***.***> wrote:
This resolves issue #1274 <#1274>.
I've added a form to the student view that allows admin/staff to edit
information about students like their name, SID, secondary auth, section,
and role. Users cannot, however, change students' email addresses since
much of the back-end code relies on using the email as an identifier. Maybe
this could be a feature in the future.
[image: screen shot 2019-01-16 at 12 30 51 am]
<https://user-images.githubusercontent.com/6360587/51228670-6a56c080-1927-11e9-802e-23cc8a931a1c.png>
[image: screen shot 2019-01-16 at 12 30 55 am]
<https://user-images.githubusercontent.com/6360587/51228694-7f335400-1927-11e9-8911-da38132043dd.png>
[image: screen shot 2019-01-16 at 12 31 37 am]
<https://user-images.githubusercontent.com/6360587/51228700-85293500-1927-11e9-8be8-da642eb1c949.png>
[image: screen shot 2019-01-16 at 12 31 45 am]
<https://user-images.githubusercontent.com/6360587/51228704-88242580-1927-11e9-9828-9b6ead8c18ec.png>
------------------------------
You can view, comment on, or merge this pull request online at:
#1346
Commit Summary
- Add form in Student View for editing enrollment information
File Changes
- *M* server/controllers/admin.py
<https://github.com/okpy/ok/pull/1346/files#diff-0> (17)
- *M* server/templates/staff/student/overview.html
<https://github.com/okpy/ok/pull/1346/files#diff-1> (29)
Patch Links:
- https://github.com/okpy/ok/pull/1346.patch
- https://github.com/okpy/ok/pull/1346.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1346>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACysaoL_0fTI1aUo1GSWbAnpnVusKwILks5vDrwqgaJpZM4aCW2N>
.
|
colinschoen
requested changes
Jan 16, 2019
server/controllers/admin.py
Outdated
| else: | ||
| email, role = form.email.data, form.role.data | ||
| Enrollment.enroll_from_form(cid, form) | ||
| flash("Edited User Successfully", 'success') |
There was a problem hiding this comment.
Nit, prefer single quotes unless a single quote is used in the string. (I know this isn't consistent everywhere).
server/controllers/admin.py
Outdated
| flash("Edited User Successfully", 'success') | ||
| else: | ||
| if form.is_submitted(): | ||
| flash("There is an issue with your request.", 'error') |
|
This might also be a nice opportunity for a test, but I won't hold you to it if you want to get it shipped now :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issue #1274.
I've added a form to the student view that allows admin/staff to edit information about students like their name, SID, secondary auth, section, and role. Users cannot, however, change students' email addresses since much of the back-end code relies on using the email as an identifier. Maybe this could be a feature in the future.